BugsFB SJ SDK no longer compatible with old versions of Prototype.js after JSON3 upgrade
- Status: Fixed
- Priority: Low
- Updated: July 31, 2012 at 7:53pm
Latest response from Facebook
Øyvind Sean Kinsey
This should now be resolved. Thanks for your patience.
Status changed to Fixed · July 31, 2012 at 7:53pm
Øyvind Sean Kinsey
We have a fix for this issue and it will be pushed soon. Stay tuned.
Status changed to Fix Ready · July 25, 2012 at 6:25pm
Noorin Ladhani
Thanks for the report. We are looking into this.
Status changed to Assigned · Priority changed to Low · May 24, 2012 at 1:09pm
You guys recently changed your JSON library to http://bestiejs.github.com/json3/. Neither it nor the previous JSON library were compatible with Prototype.js, but before that change, you had this workaround in place:
if (window.Prototype && Object.toJSON) {
return Object.toJSON(a);
} else {
return JSON.stringify(a);
}
When you updated to the new JSON library, you removed the Prototype workaround, so now a number UI dialogs and other things fail to work on websites with old versions of Prototype.
Yes, the bug is not technically in your code, but it would make my life much easier if you could put the workaround back in place.
if (window.Prototype && Object.toJSON) {
return Object.toJSON(a);
} else {
return JSON.stringify(a);
}
When you updated to the new JSON library, you removed the Prototype workaround, so now a number UI dialogs and other things fail to work on websites with old versions of Prototype.
Yes, the bug is not technically in your code, but it would make my life much easier if you could put the workaround back in place.
| Steps to Reproduce: | 1) Visit http://www.biletix.com/etkinlik/NKBKA/TURKIYE/en 2) Click the orange "Yes" button under "Who's Going?" / "Are you going?" 3) You may need to scroll up to see the dialog ( https://developers.facebook.com/bugs/198285380271199 ) 4) See that the dialog reads "An error occurred with Biletix powered by Sociable. Please try again later.". If you check the network traffic, you can see that the Array fields in the feed dialog JSON were converted to strings. |
|---|---|
| Expected Behavior: | A feed dialog should appear allowing me to share the event with friends. |
| Actual Behavior: | The dialog instead says "An error occurred with Biletix powered by Sociable. Please try again later." |
| API/SDK: | Javascript SDK |
| App IDs: |
|
1 person can reproduce this issue by following these steps
Repro